Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(settings): replace pright with jedi_language_server. #713

Merged
merged 1 commit into from
May 6, 2023

Conversation

ayamir
Copy link
Owner

@ayamir ayamir commented May 6, 2023

@CharlesChiuGit
Copy link
Collaborator

CharlesChiuGit commented May 6, 2023

can't really review the pr in a few days, my home pc just got blown up by a fking transformer accident around my house.

i need to buy a new pc 😰

@ayamir
Copy link
Owner Author

ayamir commented May 6, 2023

can't really review the pr in a few days, my home pc just got blown up by a fking transformer accident around my house.

i need to buy a new pc 😰

Wish you all the best :)

@ayamir
Copy link
Owner Author

ayamir commented May 6, 2023

We'd better merge it before 3.0.0 released and remind user to uninstall pyright mannally.

@ayamir ayamir requested a review from Jint-lzxy May 6, 2023 07:53
Copy link
Collaborator

@Jint-lzxy Jint-lzxy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ayamir ayamir merged commit 1d901b7 into main May 6, 2023
@ayamir ayamir deleted the chore/pyright-to-jedi branch May 7, 2023 02:53
boomker pushed a commit to boomker/uvcode-nvim that referenced this pull request May 10, 2023
chore(settings): replace `pright` with `jedi_language_server`.

(cherry picked from commit 1d901b7)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants